Skip to content

Conversation

@DavidWiseman
Copy link
Contributor

Fix data types. query_id and plan_id columns from query store are BIGINT. Fixes potential error: The conversion of the nvarchar value '2147483648' overflowed an int column.

Fix data types.  query_id and plan_id columns from query store are BIGINT.  Fixes potential error:
The conversion of the nvarchar value '2147483648' overflowed an int column.
@prmerger-automator
Copy link
Contributor

@DavidWiseman : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 803523e:

✅ Validation status: passed

File Status Preview URL Details
docs/relational-databases/system-dynamic-management-views/sys-dm-db-tuning-recommendations-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards v-dirichards requested a review from Copilot January 5, 2026 21:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a data type mismatch in Example 3 of the sys.dm_db-tuning-recommendations documentation. The change updates the data types for query_id, regressedPlanId, and recommendedPlanId from INT to BIGINT to match the actual data types used in SQL Server's Query Store, preventing potential integer overflow errors.

Key Changes:

  • Updated three column data type declarations from INT to BIGINT in the OPENJSON CROSS APPLY statement

@v-dirichards
Copy link
Contributor

@jovanpop-msft

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jan 5, 2026
@rwestMSFT
Copy link
Contributor

Thanks, we'll incorporate this change into an internal PR and close this one when the internal one merges.

@AnnaMHuff AnnaMHuff closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants