Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing Build() #70

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

hangy
Copy link
Contributor

@hangy hangy commented Dec 30, 2024

The suggested OpenTelemetry SDK methods return a …Builder instance. Thus, to use the TracerProvider, or the MeterProvider, they need to be built.

The suggested OpenTelemetry SDK methods return a `…Builder` instance. Thus, to use the `TracerProvider`, or the `MeterProvider`, they need to be built.
Copy link
Contributor

@hangy : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 8f5e644:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-monitor/app/opentelemetry-configuration.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

@AaronMaxwell

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Dec 30, 2024
@AaronMaxwell
Copy link
Contributor

@TimothyMothra - We have a request to modify the .NET sample code with some additional build statements. Please take a look and let me know if this should be accepted, rejected, or modified.

@AaronMaxwell
Copy link
Contributor

#assign-reviewer:TimothyMothra

Copy link
Contributor

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
Don't know how this was missed. It's in all our other docs and examples.

@v-dirichards
Copy link
Contributor

@TimothyMothra I'll merge this PR based on your approval. If this article requires further changes, please open a separate pull request.

@v-dirichards v-dirichards merged commit 4a0e7e1 into MicrosoftDocs:main Jan 2, 2025
2 checks passed
@hangy hangy deleted the patch-1 branch January 2, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants