-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing Build()
#70
Conversation
The suggested OpenTelemetry SDK methods return a `…Builder` instance. Thus, to use the `TracerProvider`, or the `MeterProvider`, they need to be built.
@hangy : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 8f5e644: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@TimothyMothra - We have a request to modify the .NET sample code with some additional build statements. Please take a look and let me know if this should be accepted, rejected, or modified. |
#assign-reviewer:TimothyMothra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Don't know how this was missed. It's in all our other docs and examples.
@TimothyMothra I'll merge this PR based on your approval. If this article requires further changes, please open a separate pull request. |
The suggested OpenTelemetry SDK methods return a
…Builder
instance. Thus, to use theTracerProvider
, or theMeterProvider
, they need to be built.