feedback for the enhanced migration guide for Application Gateway V2 #127763
Conversation
I run both new enhanced scripts and found some document errors and feedback for less confusion. 1. AzureAppGWClone script doesn't seem to have "-enableAutoScale" parameter since I got error if I added. So better to remove it from the sample script. 2. Add install script command for PIP retention script. 3. wrong script name was mentioned for PIP retention script. It should be "AzureAppGWIPMigrate"
|
@maotsuk : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
azure-application-gateway/svc
Change sent to author
labels
|
Learn Build status updates of commit e539c45: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
There was a problem hiding this comment.
Pull Request Overview
This PR corrects documentation errors in the Application Gateway V2 migration guide based on feedback from testing the enhanced migration scripts. The changes improve accuracy and clarity of the migration instructions.
Key changes:
- Removes unsupported
-enableAutoScaleparameter from the cloning script example - Adds missing installation command for the PIP retention script
- Corrects script name references from AzureAppGWClone to AzureAppGWIPMigrate
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| -privateIpAddress "10.0.0.1" ` | ||
| -publicIpResourceId "/subscriptions/aaaa0a0a-bb1b-cc2c-dd3d-eeeeee4e4e4e/resourceGroups/MyResourceGroup/providers/Microsoft.Network/publicIPAddresses/MyPublicIP" ` | ||
| -enableAutoScale | ||
There was a problem hiding this comment.
The removal of the -enableAutoScale parameter leaves an empty line in the code example. Consider removing this empty line to maintain clean formatting in the documentation.
| **Example** | ||
| ```azurepowershell | ||
| ./AzureAppGWIPMigrate.ps1 ` | ||
| AzureAppGWIPMigrate.ps1 ` |
There was a problem hiding this comment.
[nitpick] The script invocation is missing the './' prefix for consistency with PowerShell script execution conventions. Consider changing to './AzureAppGWIPMigrate.ps1' to match the corrected example pattern on line 316.
3 participants
I run both new enhanced scripts and found some document errors and feedback for less confusion.
1.(Line 106) The AzureAppGWClone script does not appear to support the -enableAutoScale parameter, as adding it results in an error. It would be better to remove this parameter from the sample script.
(Line 265) Include the command to install the PIP retention script.
(Line 324) The script name for the PIP retention script is incorrect. It should be AzureAppGWIPMigrate.