-
Notifications
You must be signed in to change notification settings - Fork 21.8k
Add clarification for SMTP username parameter #127759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Clarified the SMTP username format in the PowerShell instructions to reduce customer confusion.
|
@ahmadfoa : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 4faf27c:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/communication-services/quickstarts/email/send-email-smtp/includes/send-email-smtp-powershell.md | Details |
articles/communication-services/quickstarts/email/send-email-smtp/includes/send-email-smtp-powershell.md
- Line 32, Column 31: [Warning: disallowed-html-tag - See documentation]
HTML tag 'SMTP' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder. - Line 33, Column 47: [Warning: disallowed-html-tag - See documentation]
HTML tag 'Azure' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder. - Line 33, Column 92: [Warning: disallowed-html-tag - See documentation]
HTML tag 'Microsoft' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder. - Line 33, Column 125: [Warning: disallowed-html-tag - See documentation]
HTML tag 'Microsoft' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
|
Can you review the proposed changes? Note that before the PR can be merged you'll need to remove the explanation for the proposed update from the article and resolve the warnings in the PR by marking the user name as code. Thanks IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR clarifies the SMTP username parameter format in PowerShell documentation to help customers better understand the expected format.
Key Change:
- Added documentation explaining the SMTP username format structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Regarding the -ArgumentList '<SMTP Username>' parameter, it is causing confusion for customers, so it would be better to add this clarification | ||
| - The SMTP username should be your username- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID> |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation contains informal phrasing that should be rewritten in a more professional style. Remove the meta-commentary ('it is causing confusion for customers, so it would be better to add this clarification') and rephrase as direct instructional content. Additionally, 'your username-' appears to have incorrect punctuation and unclear meaning.
| Regarding the -ArgumentList '<SMTP Username>' parameter, it is causing confusion for customers, so it would be better to add this clarification | |
| - The SMTP username should be your username- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID> | |
| The -ArgumentList '<SMTP Username>' parameter requires the SMTP username in the following format: | |
| - <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID> |
| To store the credentials in the required PSCredential format, use the following PowerShell commands: | ||
|
|
||
| Regarding the -ArgumentList '<SMTP Username>' parameter, it is causing confusion for customers, so it would be better to add this clarification | ||
| - The SMTP username should be your username- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID> |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a space after the hyphen in 'username-'. The correct format should be 'username - ' or the hyphen should be removed entirely depending on the intended meaning.
| - The SMTP username should be your username- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID> | |
| - The SMTP username should be your username - <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID> |
Clarified the SMTP username format in the PowerShell instructions to reduce customer confusion.