Skip to content

Conversation

@ahmadfoa
Copy link

Clarified the SMTP username format in the PowerShell instructions to reduce customer confusion.

Clarified the SMTP username format in the PowerShell instructions to reduce customer confusion.
@prmerger-automator
Copy link
Contributor

@ahmadfoa : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 4faf27c:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/communication-services/quickstarts/email/send-email-smtp/includes/send-email-smtp-powershell.md ⚠️Warning Details

articles/communication-services/quickstarts/email/send-email-smtp/includes/send-email-smtp-powershell.md

  • Line 32, Column 31: [Warning: disallowed-html-tag - See documentation] HTML tag 'SMTP' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
  • Line 33, Column 47: [Warning: disallowed-html-tag - See documentation] HTML tag 'Azure' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
  • Line 33, Column 92: [Warning: disallowed-html-tag - See documentation] HTML tag 'Microsoft' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
  • Line 33, Column 125: [Warning: disallowed-html-tag - See documentation] HTML tag 'Microsoft' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@ttorble
Copy link
Contributor

ttorble commented Oct 22, 2025

@ddouglas-msft

Can you review the proposed changes? Note that before the PR can be merged you'll need to remove the explanation for the proposed update from the article and resolve the warnings in the PR by marking the user name as code. Thanks

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 22, 2025
@ttorble ttorble requested a review from Copilot October 22, 2025 15:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR clarifies the SMTP username parameter format in PowerShell documentation to help customers better understand the expected format.

Key Change:

  • Added documentation explaining the SMTP username format structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +32 to +33
Regarding the -ArgumentList '<SMTP Username>' parameter, it is causing confusion for customers, so it would be better to add this clarification
- The SMTP username should be your username- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID>
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation contains informal phrasing that should be rewritten in a more professional style. Remove the meta-commentary ('it is causing confusion for customers, so it would be better to add this clarification') and rephrase as direct instructional content. Additionally, 'your username-' appears to have incorrect punctuation and unclear meaning.

Suggested change
Regarding the -ArgumentList '<SMTP Username>' parameter, it is causing confusion for customers, so it would be better to add this clarification
- The SMTP username should be your username- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID>
The -ArgumentList '<SMTP Username>' parameter requires the SMTP username in the following format:
- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID>

Copilot uses AI. Check for mistakes.
To store the credentials in the required PSCredential format, use the following PowerShell commands:

Regarding the -ArgumentList '<SMTP Username>' parameter, it is causing confusion for customers, so it would be better to add this clarification
- The SMTP username should be your username- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID>
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a space after the hyphen in 'username-'. The correct format should be 'username - ' or the hyphen should be removed entirely depending on the intended meaning.

Suggested change
- The SMTP username should be your username- <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID>
- The SMTP username should be your username - <Azure Communication Services Resource name>.<Microsoft Entra Application ID>.<Microsoft Entra Tenant ID>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants