Skip to content

Tráfico snaps mockserver#27466

Draft
javiergarciavera wants to merge 8 commits intomainfrom
cursor/tr-fico-snaps-mockserver-9a17
Draft

Tráfico snaps mockserver#27466
javiergarciavera wants to merge 8 commits intomainfrom
cursor/tr-fico-snaps-mockserver-9a17

Conversation

@javiergarciavera
Copy link
Contributor

Route Snaps WebView network traffic through the mock server to enable full E2E test mocking on iOS and Android.

Previously, network requests originating from Snaps within SnapExecutionWebView were not intercepted by the mock server, limiting the scope of E2E test mocking. This change ensures all traffic from Snaps is captured.

Open in Web Open in Cursor 

Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
@cursor
Copy link

cursor bot commented Mar 13, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@metamaskbot metamaskbot added the team-qa QA team label Mar 13, 2026
cursoragent and others added 2 commits March 13, 2026 18:02
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
@github-actions github-actions bot added size-M and removed size-S labels Mar 13, 2026
cursoragent and others added 5 commits March 13, 2026 18:20
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
All changes are in the E2E test infrastructure layer (MockServerE2E, fixture utilities, allowlist, and WithFixtures options). The PR introduces device-level HTTP(S) proxy configuration for Android/iOS simulators and modifies how fallback ports and optional command queue debug endpoints are handled.

This impacts:

  • All tests using withFixtures (core test wrapper).
  • All tests relying on MockServerE2E for API mocking.
  • Network interception and allowlisting logic across the entire suite.
  • Command queue server behavior and fixture server port translation.

Because this is shared infrastructure used by virtually every Detox E2E flow (accounts, confirmations, trade, network selection, perps, predictions, card, ramps, snaps, multi-chain, etc.), a regression could break any vertical. The proxy changes in particular affect WebView/dApp traffic and system-level connectivity probes, which are common across SmokeConfirmations, SmokeNetworkExpansion, SmokeMultiChainAPI, and FlaskBuildTests.

Although no app production code changed, the risk is cross-cutting across all E2E flows due to network mocking and transport changes. Therefore, the safest minimal-risk strategy is to run all E2E tags to validate that:

  • Network calls are still properly intercepted and allowed.
  • Detox transport is not disrupted by proxy toggling.
  • Optional command queue debug endpoint handling does not break startup.
  • dApp/WebView-based flows (Snaps, multi-chain, swaps, confirmations) still function.

Risk is assessed as medium (not app runtime code, but high blast radius across test infra).

Performance Test Selection:
Changes are limited to E2E testing infrastructure (mock server, proxy configuration, fixtures). No production app code, rendering logic, controllers, or performance-sensitive flows were modified. Therefore, no performance tests are required.

View GitHub Actions results

@github-actions
Copy link
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants