Skip to content

feat: migrate Button to DSRN (predict scope)#27465

Draft
kirillzyusko wants to merge 6 commits intomainfrom
feat/migrate-button-predict-scope
Draft

feat: migrate Button to DSRN (predict scope)#27465
kirillzyusko wants to merge 6 commits intomainfrom
feat/migrate-button-predict-scope

Conversation

@kirillzyusko
Copy link
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@kirillzyusko kirillzyusko self-assigned this Mar 13, 2026
@kirillzyusko kirillzyusko added the team-predict Predict team label Mar 13, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kirillzyusko kirillzyusko force-pushed the feat/migrate-button-predict-scope branch from 169bba8 to 9a446ec Compare March 13, 2026 17:19
@github-actions github-actions bot added size-L and removed size-M labels Mar 13, 2026
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: @PerformancePredict
  • Risk Level: high
  • AI Confidence: 81%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR heavily modifies the Predict (Polymarket) feature, including multiple UI components (PredictBalance, PredictKeypad, PredictMarketSingle/Multiple, PredictPositionDetail, PredictOffline), buy/sell preview flows, action buttons, GTM modal, and related test IDs. It also updates a critical E2E page object (tests/page-objects/Predict/PredictDetailsPage.ts), directly impacting Detox-based test automation.

Additionally, .detoxrc.js is a critical global E2E configuration file. Changes here can affect the entire test runner configuration (devices, build configs, launch args, artifacts, retries, etc.), potentially impacting all Detox suites regardless of feature area.

Because:

  1. Predict flows involve on-chain transactions (open position, close/cash out, claim winnings) → requires SmokeConfirmations.
  2. Predict is embedded in Trending → requires SmokeWalletPlatform.
  3. SmokePredictions explicitly requires SmokeWalletPlatform and SmokeConfirmations.
  4. The Detox config change introduces cross-suite risk, potentially affecting every E2E flow.

Given the global E2E configuration change combined with extensive UI updates to a complex transactional feature, the safest risk-based strategy is to execute the full Smoke suite to ensure no regressions across navigation, confirmations, dApp/provider flows, or feature entry points.

This is classified as HIGH risk due to:

  • Global test infrastructure modification (.detoxrc.js)
  • Multiple Predict transactional UI changes
  • Updated page objects (automation surface)
  • Potential impact to navigation, confirmations, and analytics hooks

Performance Test Selection:
Multiple Predict UI components and preview screens were modified (market details, buy/sell preview, position detail, keypad, balance display). These changes can affect rendering performance, state updates, and market loading responsiveness. Running @PerformancePredict ensures prediction market list loading, deposit flows, and balance updates remain performant.

View GitHub Actions results

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 0
Missing keys 46
Type mismatches 0
Value mismatches 11 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant