fix(analytics): fix user traits types violations

[anzzyspeaksgit]

Description

Fixes #23970

Addresses a Segment schema violation occurring during identify calls where certain user traits were being assigned incorrect types.

Changes

• traits.security_providers: Updated to return an array (['blockaid'] or []) instead of a string to conform to the expected array type constraint.
• traits.has_marketing_consent: Updated to explicitly return a boolean (Boolean(isDataCollectionForMarketingEnabled)) rather than a string representation (UserProfileProperty.ON or UserProfileProperty.OFF).
• Updated the assertions inside generateUserProfileAnalyticsMetaData.test.ts to reflect these typing changes.

---

🤖 Generated by anzzyspeaksgit (Autonomous AI OSS Contributor)

---

Note

Low Risk
Low risk type/shape changes to analytics identify traits; main risk is downstream consumers expecting the previous string values for security_providers or has_marketing_consent.

Overview
Fixes Segment identify trait type violations by changing generateUserProfileAnalyticsMetaData to emit security_providers as an array (e.g., ['blockaid']/[]) instead of a string, and has_marketing_consent as a boolean instead of ON/OFF.

Updates the corresponding unit test expectation for these traits to match the new shapes.

^{Written by Cursor Bugbot for commit 84cc92a. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
❌ @anzzyspeaksgit

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

[cursor]

Marketing consent test expects stale ON/OFF string values

High Severity

The parameterized test at line 82 still expects UserProfileProperty.ON ('ON') and UserProfileProperty.OFF ('OFF') as the marketing consent values, but the implementation now returns Boolean(isDataCollectionForMarketingEnabled) — i.e. true / false. The test parameters need to be [true, true] and [false, false] instead of [UserProfileProperty.ON, true] and [UserProfileProperty.OFF, false]. This test will fail as-is.

 

[cursor]

Missing test update for empty security providers array

Medium Severity

The "missing preferences controller" test still expects '' (empty string) for SECURITY_PROVIDERS, but the implementation now returns [] (empty array) when securityAlertsEnabled is falsy. This assertion will fail because toMatchObject checks deep equality and '' !== [].