Skip to content

fix: fix stop loss banner debounce #27458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gambinish wants to merge 3 commits into
base: main
Choose a base branch
from
+83 −223
Open

fix: fix stop loss banner debounce #27458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6715f86
fix: stop loss prompt banner
gambinish Mar 12, 2026
35d8331
fix: stop loss banner debounce
gambinish Mar 12, 2026
32d3e84
fix: update unit tests
gambinish Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/components/UI/Perps/Views/PerpsMarketDetailsView/PerpsMarketDetailsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,6 @@ const PerpsMarketDetailsView: React.FC<PerpsMarketDetailsViewProps> = () => {
}, [candleData, selectedCandlePeriod, visibleCandleCount]);

// Check if user has an existing position for this market
// Also provides positionOpenedTimestamp for stop loss prompt timing
const {
isLoading: isLoadingPosition,
existingPosition,
Expand Down
5 changes: 0 additions & 5 deletions app/components/UI/Perps/constants/perpsConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,6 @@ export const STOP_LOSS_PROMPT_CONFIG = {
// No banner shown until ROE drops below this value
MinLossThreshold: -10,

// Debounce duration for ROE threshold (milliseconds)
// User must have ROE below threshold for this duration before showing banner
// Prevents banner from appearing during temporary price fluctuations
RoeDebounceMs: 60_000, // 60 seconds

// Minimum position age before showing any banner (milliseconds)
// Prevents banner from appearing immediately after opening a position
PositionMinAgeMs: 120_000, // 2 minutes
Expand Down
Loading
Loading