Skip to content

fix(tests): add priority parameter to setupRemoteFeatureFlagsMock for… #27445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmd-ob wants to merge 9 commits into
base: main
Choose a base branch
from
+22 −9
Open

fix(tests): add priority parameter to setupRemoteFeatureFlagsMock for… #27445

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aea04c5
fix(tests): add priority parameter to setupRemoteFeatureFlagsMock for…
cmd-ob Mar 12, 2026
acf613e
fix(tests): update feature flags priority in createMockAPIServer for …
cmd-ob Mar 12, 2026
a737fee
Merge branch 'main' into fix/ramps-test
cmd-ob Mar 12, 2026
8818ed0
fix(tests): simplify setupRemoteFeatureFlagsMock by consolidating moc…
cmd-ob Mar 12, 2026
57fc671
Merge branch 'main' into fix/ramps-test
cmd-ob Mar 12, 2026
27aada0
Merge branch 'main' into fix/ramps-test
cmd-ob Mar 12, 2026
8542832
unskip ramps
cmd-ob Mar 12, 2026
e4607ff
Merge branch 'fix/ramps-test' of github.com:MetaMask/metamask-mobile …
cmd-ob Mar 12, 2026
bd350db
feat: Add test ID to Continue button in BuildQuote component
cmd-ob Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions tests/api-mocking/helpers/remoteFeatureFlagsHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ export const createRemoteFeatureFlagsMock = (
export const setupRemoteFeatureFlagsMock = async (
mockServer: Mockttp,
flagOverrides: Record<string, unknown> = {},
priority?: number,
): Promise<void> => {
const environments = ['dev', 'test', 'prod'] as const;
const distributions = ['main', 'flask'] as const;
Expand All @@ -140,12 +141,16 @@ export const setupRemoteFeatureFlagsMock = async (
const { urlEndpoint, response, responseCode } =
createRemoteFeatureFlagsMock(flagOverrides, distribution, environment);

return setupMockRequest(mockServer, {
requestMethod: 'GET',
url: urlEndpoint,
response,
responseCode,
});
return setupMockRequest(
mockServer,
{
requestMethod: 'GET',
url: urlEndpoint,
response,
responseCode,
},
priority,
);
}),
);

Expand Down
14 changes: 11 additions & 3 deletions tests/framework/fixtures/FixtureHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,9 +461,17 @@ export const createMockAPIServer = async (
// Additional Global Mocks
await mockNotificationServices(mockServer);

// Feature Flags
// testSpecificMock can override this if needed
await setupRemoteFeatureFlagsMock(mockServer);
// Feature Flags — registered at priority 2 so testSpecificMock rules at
// priority 999 always win for every subsequent fetch.
// RemoteFeatureFlagController polls every 1 second in DEV mode; without this
// priority separation the default mock would override test-specific flag
// overrides on the second request, breaking flag-dependent flows mid-test.
//
// Priority 2 (not 1) is intentional: the MockServerE2E catch-all /proxy handler
// uses mockttp's DEFAULT priority (1). Priority 2 ensures this default feature
// flags mock wins over the catch-all for tests that have no testSpecificMock,
// preventing unmocked live requests to client-config.api.cx.metamask.io.
await setupRemoteFeatureFlagsMock(mockServer, undefined, 2);

const endpoints = await mockServer.getMockedEndpoints();
logger.debug(`Mocked endpoints: ${endpoints.length}`);
Expand Down
Loading