Skip to content

feat: migrate Skeleton component (confirmations scope)#27433

Draft
kirillzyusko wants to merge 1 commit intomainfrom
feat/skeleton-migration-confirmations-scope
Draft

feat: migrate Skeleton component (confirmations scope)#27433
kirillzyusko wants to merge 1 commit intomainfrom
feat/skeleton-migration-confirmations-scope

Conversation

@kirillzyusko
Copy link
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@kirillzyusko kirillzyusko self-assigned this Mar 12, 2026
@kirillzyusko kirillzyusko added the team-confirmations Push issues to confirmations team label Mar 12, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations, SmokePredictions, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
All changed files are within the confirmations UI layer (app/components/Views/confirmations/...). These components directly impact transaction and signature confirmation flows, including send flows (from-to-row, gas-fee-details-row, network-and-origin-row, hero-row, advanced-details-row, custom-amount), token payments (pay-token-amount, pay-with-row), and general confirmation layout (footer, info-row). This makes SmokeConfirmations mandatory.

Additionally, there are changes to predict-specific confirmation UI (predict-claim-amount), which directly affects the Predictions transaction lifecycle (claiming winnings). Per tag requirements, selecting SmokePredictions also requires SmokeConfirmations and SmokeWalletPlatform because Predictions is embedded in Trending and uses on-chain confirmations.

SmokeWalletPlatform is included due to its ownership of the Trending tab (which embeds Predictions) and shared wallet activity/confirmation display integrations that could be impacted by confirmation UI changes.

No changes were made to controllers, Engine, network layer, account management, Snaps, Card, Perps, or MultiChain APIs, so those tags are not required.

Performance Test Selection:
Changes are limited to UI components within the confirmation screen without evidence of architectural, rendering-loop, list virtualization, or data-loading modifications. No Engine, controller, or heavy list components were modified. Therefore, no dedicated performance test suites are required.

View GitHub Actions results

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant