Skip to content

feat: migrate Skeleton (rewards scope)#27428

Merged
kirillzyusko merged 1 commit intomainfrom
feat/skeleton-migration-rewards-scope
Mar 16, 2026
Merged

feat: migrate Skeleton (rewards scope)#27428
kirillzyusko merged 1 commit intomainfrom
feat/skeleton-migration-rewards-scope

Conversation

@kirillzyusko
Copy link
Contributor

@kirillzyusko kirillzyusko commented Mar 12, 2026

Description

Migrate Skeleton to use DSRN.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-274

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-12.at.15.17.49.mov

After

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-12.at.15.15.42.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Mostly mechanical import/mocking changes to swap Rewards screens and tests over to the new components-temp Skeleton; functional risk is limited to loading placeholders rendering/autoPlay behavior.

Overview
Migrates the Rewards UI (onboarding, season status, previous season, referral details, settings, and tabs) to use the new design-system-backed Skeleton from component-library/components-temp/Skeleton instead of the legacy component.

Updates associated unit tests to mock the new Skeleton module paths and types so loading-state coverage continues to pass.

Written by Cursor Bugbot for commit b310d00. This will update automatically on new commits. Configure here.

@kirillzyusko kirillzyusko self-assigned this Mar 12, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kirillzyusko kirillzyusko added the team-rewards Rewards team label Mar 12, 2026
@kirillzyusko kirillzyusko marked this pull request as ready for review March 12, 2026 14:30
@kirillzyusko kirillzyusko requested a review from a team as a code owner March 12, 2026 14:30
Montoya
Montoya previously approved these changes Mar 12, 2026
@kirillzyusko kirillzyusko force-pushed the feat/skeleton-migration-rewards-scope branch from ecfa0d6 to b310d00 Compare March 13, 2026 11:13
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
All changed files are confined to the Rewards UI feature under app/components/UI/Rewards/ along with their corresponding unit tests. There are no changes to core wallet functionality (Engine, Controllers, navigation, confirmations, network management, trade flows, identity, snaps, etc.) and no modifications to shared components like Browser, TabBar, Modals, or Confirmations. The Rewards feature is not covered by any of the available Detox E2E smoke tags listed, and none of the tag descriptions reference Rewards-related flows. Therefore, running existing E2E smoke suites would not provide additional validation value for these isolated UI changes. The risk of regression to critical wallet flows is low.

Performance Test Selection:
Changes are limited to Rewards UI components and related presentation logic. There are no modifications to performance-critical flows such as onboarding, login, app launch, swaps, asset loading, predictions, or perps. No controller, data layer, or large list rendering infrastructure changes were introduced. Therefore, performance tests are not required.

View GitHub Actions results

@kirillzyusko kirillzyusko requested a review from Montoya March 13, 2026 11:17
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.97%. Comparing base (d6fd3c4) to head (b310d00).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #27428      +/-   ##
==========================================
- Coverage   81.97%   81.97%   -0.01%     
==========================================
  Files        4756     4756              
  Lines      123700   123700              
  Branches    27353    27353              
==========================================
- Hits       101409   101408       -1     
- Misses      15285    15286       +1     
  Partials     7006     7006              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@kirillzyusko kirillzyusko enabled auto-merge March 13, 2026 12:11
@kirillzyusko kirillzyusko added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit 3456a82 Mar 16, 2026
62 checks passed
@kirillzyusko kirillzyusko deleted the feat/skeleton-migration-rewards-scope branch March 16, 2026 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-M team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants