Skip to content

Conversation

@oscarwroche
Copy link

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

dawnseeker8 and others added 8 commits October 17, 2025 15:09
- Added a new status 'SUBMITTED' to the INTENT_STATUS object.
- Updated the logic in TransactionElement to handle the new 'SUBMITTED' status correctly, defaulting to 'FAILED' for unknown statuses.
- Bumped versions of @metamask/bridge-controller and @metamask/bridge-status-controller in yarn.lock, along with their corresponding checksums and resolutions.
- Updated @metamask/transaction-controller version to 60.9.0 in yarn.lock.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

1 out of 2 committers have signed the CLA.
@dawnseeker8
@oscarwroche

@github-actions github-actions bot added the size-M label Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade, SmokeSwaps, SmokeConfirmationsRedesigned, SmokeAssets
  • Risk Level: high
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

This PR introduces significant changes to the bridge/swap functionality with new CowSwap intent transaction support:

  1. Critical Engine Changes: The transaction-controller-messenger.ts adds new allowedActions including BridgeStatusController:submitTx, KeyringController:signTypedMessage, and DelegationController:signDelegation - this is core infrastructure.

  2. New Intent Transaction Feature: A new intent.ts file adds CowSwap order signing capability, which is a new transaction type for intent-based bridge transactions.

  3. Bridge Submission Changes: useSubmitBridgeTx.ts now routes intent transactions through a separate code path using handleIntentTransaction().

  4. Transaction UI Changes: TransactionElement/index.js adds intent status mapping (SUBMITTED, PENDING, COMPLETE, FAILED) and modifies how bridge transaction status is displayed.

  5. Package Changes (DEV-ONLY): package.json points to local file paths for bridge-controller, bridge-status-controller, and transaction-controller - this won't work in production and indicates this is development/testing setup.

  6. Bridge API Points to localhost: BRIDGE_API_BASE_URL changed to localhost:3000 - clearly a dev setup.

The changes are high-risk because they modify:

  • Core transaction controller messaging
  • Transaction submission flows for bridges
  • Transaction history lookup logic
  • Transaction list UI rendering

Recommended tags:

  • SmokeTrade: Directly tests bridge functionality (bridge-action-smoke.spec.ts exists)
  • SmokeSwaps: Related swap functionality that shares infrastructure
  • SmokeConfirmationsRedesigned: Transaction confirmation flows may be affected by the new intent transaction types and controller messenger changes
  • SmokeAssets: Transaction element changes affect how transactions appear in activity view

View GitHub Actions results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants