Testing enhanced gesture approach

[brianacnguyen]

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Refines gesture handling across buttons/list items and tunes BottomSheet pan thresholds to improve responsiveness and interaction with other gestures.

• Gestures (Android components):
  • ButtonBase / ListItemSelect / ListItemMultiSelect:
    • Add native gesture with disallowInterruption(true) and use Gesture.Simultaneous(native, tap).
    • Shorten tap maxDuration to 200 and remove requireExternalGestureToFail.
    • Accessibility: default isScreenReaderEnabled state to false, add error fallback, and only use TouchableOpacity onPress when accessibility is explicitly true.
• BottomSheetDialog:
  • Configure PanGestureHandler with shouldCancelWhenOutside=false, activeOffsetY={[-10, 10]}, and activeOffsetX={[-50, 50]} to reduce unintended cancellations and improve gesture activation.

^{Written by Cursor Bugbot for commit 183c4cf. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sleepytanya]

@brianacnguyen
QA builds https://app.bitrise.io/app/be69d4368ee7e86d/installable-artifacts/f764ec5477b1daa4

• can't click Confirm / Cancel in Solana Send
• Got it in Perps is unresponsive
• sometimes Add Funds for certain tokens also appears to be unresponsive (XPR-USD), intermittent
• token switch works as expected in Buy-Withdraw, Deposit doesn't load (unrelated to current PR)

touch.mov

[cursor]

Bug: Accessibility State Causes Component Unresponsiveness

Initializing isAccessibilityEnabled to false and changing the TouchableOpacity onPress condition to isAccessibilityEnabled === true removes a safe fallback. This causes components to rely solely on the gesture handler when accessibility state is false or unknown, leading to unresponsive buttons and list items, especially during initial loading or for accessibility users.

Additional Locations (2)

• app/component-library/components/List/ListItemSelect/ListItemSelect.tsx#L39-L127
• app/component-library/components/Buttons/Button/foundation/ButtonBase/ButtonBase.tsx#L45-L134

 

[sonarqubecloud]

Quality Gate failed

Failed conditions
7.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[Unik0rnMaggie]

Testing the QA build from above, the following issues are present:

• Solana send: confirm and cancel buttons unresponsive
• Add popular network: confirm and cancel buttons are unresponsive
• Accounts list Details button is unresponsive
• Edit account name not possible: clicking on edit account brings up the keyboard, but account cannot be edited
• Account names did not preserve
• Clicking on Wallet details from Account details is unresponsive
• Unknown Network address when clicking on Receive button
• Cannot scroll the token list in Deposit/Buy/withdraw - intermittent

Cancel.confirm.solana.and.add.network.mp4

Account.list.and.details.unknown.address.in.Receive.mp4

buy.deposit.withdraw.scroll.token.list.mp4