Skip to content

Conversation

christopherferreira9
Copy link
Contributor

@christopherferreira9 christopherferreira9 commented Oct 17, 2025

Description

This PR cleans the /framework folder and moves coded that is not related to the framework out.
The old framework has also been removed and all specs were migrated to the new framework.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Replaces legacy e2e utils with framework modules across specs, deletes old utils, adds deep-link scheme support and web element typing, and updates fixtures/ESLint accordingly.

  • E2E Framework Migration:
    • Update specs/pages to import Assertions, Matchers, Gestures, Utilities, and SoftAssert from e2e/framework/* instead of e2e/utils/*.
    • Remove legacy files in e2e/utils/ (Assertions.js, Gestures.js, Matchers.js, Utilities.js).
    • Replace PerpsE2E with specs/perps/helpers/perps-modifiers using framework deep links.
  • Deep Links & Constants:
    • Add E2EDeeplinkSchemes to e2e/framework/Constants.ts.
    • Enhance e2e/framework/DeepLink.ts with logging and generic scheme mapping for Android.
  • Gestures Enhancements:
    • Add Gestures.typeInWebElement and use it in webview interactions.
  • Fixtures/Helpers:
    • Switch fixture/helper imports to framework Utilities; adjust server/mock setup usage.
  • ESLint:
    • Trim rules in e2e/framework/.eslintrc.js (remove page-specific no-restricted-import paths).

Written by Cursor Bugbot for commit 314a97f. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 added the run-android-flask-e2e-smoke Run Android flask E2E tests on next CI run label Oct 17, 2025
@metamaskbot metamaskbot added the team-qa QA team label Oct 17, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 17, 2025
Copy link

@christopherferreira9 christopherferreira9 marked this pull request as ready for review October 20, 2025 13:17
@christopherferreira9 christopherferreira9 requested review from a team as code owners October 20, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed run-android-flask-e2e-smoke Run Android flask E2E tests on next CI run size-XL team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants