Skip to content

Conversation

jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Oct 17, 2025

Description

Detox retries the whole spec files by re-starting the jest runner. This is overwriting the junit xml report just with the scenarios of the last retry, which is causing wrong numbers in the test report.

This PR is adding a unique jest xml report, to later on merge them in a single one keeping the results of the last retry.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Merges Detox JUnit XMLs, switches workflows to unified artifacts with JSON reports, reduces flaky test retries to 1, timestamps JUnit files, and adds SRP import tests.

  • CI/Workflows:
    • Collect and upload unified test artifacts (*-test-*) instead of separate results; adjust reporter paths to all-test-artifacts/**/junit.xml.
    • Add step to merge Detox JUnit XMLs into a single junit.xml; rename artifact names (JUnit results/screenshots).
    • Generate and upload JSON test reports for smoke suites.
  • Reporting/Test Runner:
    • e2e/jest.e2e.config.js: Emit timestamped JUnit files (junit-<ISO>.xml).
    • .github/scripts/e2e-create-json-test-report.mjs: Update default inputs and output path.
    • New .github/scripts/e2e-merge-detox-junit-reports.mjs to deduplicate/merge per-test latest results.
  • Flakiness handling:
    • .github/scripts/e2e-split-tags-shards.mjs: Reduce duplicated retry specs from 2 to 1 and adjust expansion/messages.
  • Tests:
    • e2e/specs/accounts/import-srp.spec.ts: Add additional SRP import cases (including Android-conditional) expecting Account 2.

Written by Cursor Bugbot for commit c3b289d. This will update automatically on new commits. Configure here.

@jvbriones jvbriones added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 17, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Oct 17, 2025
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-M and removed size-XS labels Oct 17, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-L and removed size-M labels Oct 19, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@jvbriones jvbriones added the skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) label Oct 19, 2025
@jvbriones jvbriones removed the skip-e2e-quality-gate Skips the E2E Quality gate (flakiness detection) label Oct 20, 2025
Copy link

@jvbriones jvbriones added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit 340c72a Oct 20, 2025
251 of 269 checks passed
@jvbriones jvbriones deleted the chore-test-reports branch October 20, 2025 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-L team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants