Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand button for better DApp UX #12832

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheBojda
Copy link

The expand button hides the bottom bar and the header.

Description

I've added a new option to the browser tab menu that expands the browser. Now the app header and the bottom bar need too much space, which degrades the DApp user experience. Users can hide these components with the expand button to see the DApp as a real app.

Related issues

This PR is related to this: https://community.metamask.io/t/pr-for-fullscreen-in-mobile-metamask-browser/29933

Manual testing steps

  1. Go to the browser page
  2. Open a DApp page
  3. In the menu, choose 'Expand'
  4. You can change back by the small 'compress' button on the top right

Screenshots/Recordings

image

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Expand button hides the bottom bar and the header.
@TheBojda TheBojda requested a review from a team as a code owner December 26, 2024 11:12
Copy link
Contributor

github-actions bot commented Dec 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@TheBojda
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants