-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STAKE-808: graph with historic vault apy tooltip #12804
base: main
Are you sure you want to change the base?
feat: STAKE-808: graph with historic vault apy tooltip #12804
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected] |
e121cd6
to
f7b65ad
Compare
numericChainId, | ||
); | ||
// TODO: Determine how we should refresh this value. | ||
dispatch(setVaultAprs(vaultAprsResponse)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitabh94 @nickewansmith How do you guys think we should keep redux values up to date? If we store the vaultAprs
in our redux store when and how do we refresh it? We can fetch on render (hit the staking-api
cache) but this will require a skeleton loader state so we don't get pop-in.
Curious to hear your thoughts 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also fetch/refresh the data in the input view itself and then either pass the data as prop or get data in the component directly from the selector.
f7b65ad
to
aa5c436
Compare
Description
This PR updates the existing pooled-staking learn more modal to include an interactive historic vault APY graph.
Changes
<InteractiveTimespanChart />
component that is meant to be reusable in other flows (e.g. stablecoin lending)useVaultAprs
anduseVaultApys
hooksstake-sdk
under the hood to fetch data.vaultAprs
andvaultApys
to our staking redux stateRelated issues
Ticket: [FE]Graph with vault historic APY in tooltip
Manual testing steps
"?"
next toMetaMask Pool
Screenshots/Recordings
Before
stake-808-learn-more-modal-with-interactive-graph-before.mov
After
stake-808-learn-more-modal-with-interactive-graph-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist