chore: prioritize price-api for currencyRateController exchange rates… #36986
+116
−313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
commented
Oct 20, 2025
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [5ed1d3d]
UI Startup Metrics (1252 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [aaef5d0]
UI Startup Metrics (1251 ± 60 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [7ed57a5]
UI Startup Metrics (1234 ± 88 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [4516fb4]
UI Startup Metrics (1299 ± 99 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
4 tasks
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [0928c64]
UI Startup Metrics (1279 ± 102 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sahar-fehri
added a commit
to MetaMask/core
that referenced
this pull request
Oct 28, 2025
…er (#6863) ## Explanation PR to update the `CurrencyRatesController` so it uses the Price API for exchange rates, with CryptoCompare as a fallback. ## References * Related to extension: MetaMask/metamask-extension#36986 * Related to mobile: MetaMask/metamask-mobile#21523 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > CurrencyRateController now uses the Price API (with CryptoCompare fallback) via a new required tokenPricesService, and CodefiTokenPricesServiceV2 adds fetchExchangeRates. > > - **Controllers**: > - **CurrencyRateController**: Fetches exchange rates from Price API via `tokenPricesService.fetchExchangeRates`, with fallback to CryptoCompare; updates polling and state mapping; requires new constructor arg `tokenPricesService` (BREAKING). > - **Token Prices Service**: > - **Abstract API**: Adds `ExchangeRate`/`ExchangeRatesByCurrency` types and new `fetchExchangeRates(args)`. > - **CodefiTokenPricesServiceV2**: Implements `fetchExchangeRates` using `/v1/exchange-rates`, supports optional USD rate merging, retries/circuit-breaker hooks, and filtering. > - **Tests**: > - Update `CurrencyRateController.test.ts` to assert Price API path, fallback behavior, USD inclusion, and polling; adjust mocks across related tests to include `fetchExchangeRates`. > - **Docs/Meta**: > - Update `CHANGELOG.md` with breaking change and new functionality. > - Minor lint threshold updates. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d22e0af. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
salimtb
previously approved these changes
Oct 30, 2025
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [2ab1ee7]
UI Startup Metrics (1261 ± 98 ms)
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [3ad4311]
UI Startup Metrics (1244 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Oct 30, 2025
juanmigdr
approved these changes
Oct 30, 2025
metamaskbot
added
the
release-13.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to introduce fetching exchangeRates from price api and fallback to crypto compare.
Do not merge until this goes in MetaMask/core#6863
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-10-22.at.14.35.00.mov
After
Screen.Recording.2025-10-22.at.14.31.27.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Integrates Codefi price API into
CurrencyRateControllerand includes multichain asset state in balance calculations; wiresallIgnoredAssetsacross state/Sentry and bumps key deps.CodefiTokenPricesServiceV2intoCurrencyRateControllerviatokenPricesService; update init and tests/mocks.getAllIgnoredAssetsand include{ accountsAssets, assetsMetadata, allIgnoredAssets }in balance and balance-change selectors (selectBalanceForAllWallets, etc.).metamask.allIgnoredAssetsto app state, Sentry background/UI masks, mock states, and snapshots.@metamask/assets-controllersto^85.0.0and@metamask/controller-utilsto^11.15.0; remove yarn patch for controller-utils and lockfile updates.allIgnoredAssets.Written by Cursor Bugbot for commit 3ad4311. This will update automatically on new commits. Configure here.