Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete keys #29372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Open

chore: Remove obsolete keys #29372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/scripts/metamask-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,8 +761,6 @@ export default class MetamaskController extends EventEmitter {
}),
});

this.nftController.setApiKey(process.env.OPENSEA_KEY);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was still being set, but it did nothing: https://github.com/MetaMask/core/blob/f8e5f2e3cadecc44c1c5b40b3ed3c36d154346cb/packages/assets-controllers/src/NftController.ts#L1382

(see that the key isn't used anywhere).


const nftDetectionControllerMessenger =
this.controllerMessenger.getRestricted({
name: 'NftDetectionController',
Expand Down
11 changes: 7 additions & 4 deletions builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,9 @@ env:
# API keys to 3rd party services
###

- PUBNUB_PUB_KEY: null
- PUBNUB_SUB_KEY: null
- SEGMENT_HOST: null
- SENTRY_DSN: null
- SENTRY_DSN_DEV: null
- OPENSEA_KEY: null
- ETHERSCAN_KEY: null
# also INFURA_PROJECT_ID below

###
Expand Down Expand Up @@ -318,3 +314,10 @@ env:
# This should NEVER be enabled in production since it slows down react
###
- ENABLE_WHY_DID_YOU_RENDER: false

###
# Unused environment variables referenced in dependencies
# Unset environment variables cause a build error. These are set to `null` to tell our build
# system that they are intentionally unset.
###
- ETHERSCAN_KEY: null # Used by `gridplus-sdk/dist/util.js`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not being exfiltrated or anything. Gridplus optionally uses it to fetch contract calldata from Etherscan.

Loading