-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import all detected tokens automatically #29357
Open
sahar-fehri
wants to merge
7
commits into
main
Choose a base branch
from
feat/import-detected-tokens-automatically
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+122
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
added
the
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
label
Dec 20, 2024
tested with and without the feature flag on , works as expected , PR approved but you need to check the failing e2e test |
salimtb
previously approved these changes
Dec 20, 2024
salimtb
previously approved these changes
Dec 20, 2024
Builds ready [eae8fbb]
Page Load Metrics (1686 ± 95 ms)
Bundle size diffs
|
bergeron
reviewed
Dec 20, 2024
bergeron
reviewed
Dec 20, 2024
Builds ready [276a98e]
Page Load Metrics (1692 ± 67 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have most users autodetect tokens, we can make the UX even more streamlined. This PR automatically add in tokens we detect on behalf of users.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-439
Manual testing steps
Make sure the token detection is working properly:
Screenshots/Recordings
Before
Screen.Recording.2024-12-20.at.11.28.14.mov
After
Screen.Recording.2024-12-20.at.11.25.27.mov
Pre-merge author checklist
Pre-merge reviewer checklist