-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snaps): Settings Page #29234
feat(snaps): Settings Page #29234
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
e59b239
to
47c7677
Compare
ui/components/app/snaps/snap-settings-page/snap-settings-renderer.tsx
Outdated
Show resolved
Hide resolved
interfaceId={interfaceId} | ||
isLoading={loading} | ||
useDelineator={false} | ||
contentBackgroundColor={BackgroundColor.backgroundDefault} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The settings page having a backgroundDefault
background color interferes with some of our components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we fix the clash by forcing a background or is there additional problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clash still exists, the primary problem is with Section
that has the same background color
@@ -177,7 +177,7 @@ describe('TypedSignInfo', () => { | |||
type: TransactionType.signTypedData, | |||
chainId: '0x5', | |||
}); | |||
(snapUtils.isSnapId as jest.Mock).mockReturnValue(false); | |||
(snapUtils.isSnapId as unknown as jest.Mock).mockReturnValue(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a type error now that the function is written in typescript
Builds ready [44fb407]
Page Load Metrics (1782 ± 116 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR adds a settings section for each preinstalled snaps that exposes a
onSettingsPage
handlerRelated issues
Fixes: MetaMask/snaps#2874
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist