address more requested changes

MetaMask · Dec 17, 2024 · 44fb407 · 44fb407
1 parent a73a132
commit 44fb407
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/ui/hooks/snaps/useSnapSettings.ts b/ui/hooks/snaps/useSnapSettings.ts
@@ -13,22 +13,20 @@ export function useSnapSettings({ snapId }: { snapId?: string }) {
 
   useEffect(() => {
     let cancelled = false;
-    async function fetchPage() {
+    async function fetchPage(id: string) {
       try {
         setError(undefined);
         setLoading(true);
 
-        const newData = snapId
-          ? ((await handleSnapRequest({
-              snapId,
-              origin: '',
-              handler: 'onSettingsPage',
-              request: {
-                jsonrpc: '2.0',
-                method: ' ',
-              },
-            })) as { id: string })
-          : undefined;
+        const newData = (await handleSnapRequest({
+          snapId: id,
+          origin: '',
+          handler: 'onSettingsPage',
+          request: {
+            jsonrpc: '2.0',
+            method: ' ',
+          },
+        })) as { id: string };
         if (!cancelled) {
           setData(newData);
           forceUpdateMetamaskState(dispatch);
@@ -43,7 +41,7 @@ export function useSnapSettings({ snapId }: { snapId?: string }) {
         }
       }
     }
-    fetchPage();
+    snapId && fetchPage(snapId);
     return () => {
       cancelled = true;
     };