fix: Downgrade multiformats
to ^9.9.0
to avoid ESM-only dependency
#6920
+24
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
assets-controllers
currently uses an ESM-only version ofmultiformats
, which is not supported in the Browserify pipeline used by the extension. I suggest downgrading to ^9.9.0` (the latest CJS version), and updating to a newer version once we drop Browserify in the extension instead.References
Checklist
Note
Downgrades
multiformats
to^9.9.0
and updates IPFS CID handling to a CJS-compatible import with added type stubs.multiformats
from^13.1.0
to^9.9.0
inpackages/assets-controllers/package.json
.src/assetsUtil.ts
, replace dynamicimport('multiformats')
withimport { CID } from 'multiformats/cid'
forgetIpfsCIDv1AndPath
.multiformats/cid
atsrc/types/vendor/multiformats.d.ts
.multiformats
downgrade.Written by Cursor Bugbot for commit 8be7611. This will update automatically on new commits. Configure here.