fix: fix addTokens call with an already added tokens to state #6829
+78
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahar-fehri
commented
Oct 14, 2025
| ); | ||
| }); | ||
|
|
||
| it('should not add duplicate tokens to state', async () => { |
There was a problem hiding this comment.
This test fails on main and state.allTokens ends up with duplicate entries of the same token
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When we first call the function
addTokenswith an array of tokens to import, and then call it again with the exact same token, we notice thatstate.allTokensis updated with duplicate entries of the same token.state.allTokensare stored in checksum format.When initially state already has USDC token for a user address; and a call to
addTokensis made with a lowercase USDC address. The newTokensMap in this linecore/packages/assets-controllers/src/TokensController.ts
Line 514 in 9f480c8
The fix converts the tokensToImport received in the call to the checksum format.
References
Checklist
Note
Normalize token addresses to checksum in
TokensController.addTokensto dedupe and avoid duplicate entries when the same token is added multiple times.tokensToImportaddresses to checksum and use checksummed list for deduping/updates inaddTokens, preventing duplicate entries instate.allTokens.state.allTokens.Written by Cursor Bugbot for commit 6df8521. This will update automatically on new commits. Configure here.