-
-
Notifications
You must be signed in to change notification settings - Fork 253
refactor: migrate assets controllers messenger #6745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mikesposito/messenger/polling-controllers
Are you sure you want to change the base?
refactor: migrate assets controllers messenger #6745
Conversation
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
6a27d5a
to
6e80728
Compare
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that Cursor noticed.
AllEvents, | ||
RootMessenger | ||
>({ | ||
namespace: controllerName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it does seem that we need a parent
option here.
…sito/messenger/assets-controllers
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
Explanation
This PR migrates all remaining assets controllers to
@metamask/messenger
instead of@metamask/base-controller
. This is part of a larger effort to migrate all controllers to use@metamask/messenger
.References
Checklist
Note
Replaces RestrictedMessenger with @metamask/messenger and adopts @metamask/base-controller/next across assets controllers and tests, updating metadata and event wiring accordingly.
MultichainAssetsController
,MultichainBalancesController
,NftDetectionController
,RatesController
, andTokenSearchDiscoveryDataController
to use@metamask/messenger
(replacemessagingSystem
calls and publish/subscribe) and@metamask/base-controller/next
types.StateMetadata
withincludeInDebugSnapshot
and adjustderiveStateFromMetadata
usages.getRestricted
with namespacedMessenger
+delegate
; update imports and type utilities (MessengerActions
,MessengerEvents
,MOCK_ANY_NAMESPACE
).Written by Cursor Bugbot for commit 564f730. This will update automatically on new commits. Configure here.