Add Midas Tech (MIDAS) Token Metadata #1584
Conversation
Add Midas Tech token logo
Added metadata for Midas Tech (MIDAS) token on BNB Smart Chain. Includes symbol, decimals, logo, and project details for MetaMask integration.
backofficemidasgroup-ship-it
requested review from
a team and
MRabenda
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Fix Midas Tech (MIDAS) metadata: correct logo path, address, and website
|
Hello MetaMask team, This PR adds the MIDAS token contract metadata for BNB Smart Chain. Kindly review and approve when possible. |
|
Update please JSON to follow same pattern as other tokens - for example https://github.com/MetaMask/contract-metadata/pull/1616/files |
| "symbol": "MIDAS", | ||
| "decimals": 18, | ||
| "chainId": 56, | ||
| "logoURI": "https://raw.githubusercontent.com/backofficemidasgroup-ship-it/contract-metadata/master/images/0xA059080853B2f273A452424859a4701A1Ce13A0e.svg", |
There was a problem hiding this comment.
Logo URL points to external fork repository
High Severity
The logoURI field points to https://raw.githubusercontent.com/backofficemidasgroup-ship-it/contract-metadata/... which is a personal fork repository rather than the official MetaMask repository. All other tokens in this repository use the logo field with a relative path format like "./icons/eip155:56/erc20:0x....svg". The external URL will fail to resolve the logo since that fork may not exist or be accessible. The image was added to images/eip155:56/ but the URL path also incorrectly references images/ without the chain directory.
metadata/eip155:56/erc20:0xa059080853b2f273a452424859a4701a1ce13a0e.json
Show resolved
Hide resolved
| <path style=" stroke:none;fill-rule:nonzero;fill:rgb(89.803922%,63.529414%,11.372549%);fill-opacity:1;" d="M 47.800781 177.300781 C 43.101562 170.199219 42.300781 168.5 39.5 161 C 35.699219 150.300781 34 140.398438 34 128.199219 C 34 100.800781 44.398438 77.300781 65 57.601562 C 72.699219 50.300781 75.898438 48.101562 85.398438 43.5 C 114.5 29.199219 147.300781 30.398438 175.199219 46.699219 C 183.5 51.5 183.398438 52.699219 175.101562 48.5 C 159.699219 40.800781 150 38.199219 133.5 37.300781 C 91.898438 35.199219 56.398438 59.699219 41.699219 100.5 C 38 110.898438 36.699219 121.101562 37.300781 134.699219 C 37.898438 149 40.398438 159.101562 46.5 171.800781 C 48.898438 176.800781 50.800781 181 50.601562 181 C 50.398438 181 49.199219 179.300781 47.800781 177.300781 Z M 47.800781 177.300781 "/> | ||
| <path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 80 128 L 80 80 L 101.601562 80 L 114.5 99 C 121.601562 109.5 127.601562 118 127.898438 118 C 128.199219 117.898438 134.5 109.398438 141.800781 99 L 155.101562 80 L 176 80 L 176 176 L 155 176 L 154.800781 144.800781 L 154.5 113.5 L 141.699219 132.300781 C 134.601562 142.601562 128.398438 151 128 150.800781 C 127.5 150.601562 121.398438 142.300781 114.5 132.300781 C 107.601562 122.300781 101.5 113.800781 100.800781 113.398438 C 100 112.898438 99.898438 120.898438 100.398438 144.300781 L 101.199219 176 L 80 176 Z M 80 128 "/> | ||
| </g> | ||
| </svg> |
There was a problem hiding this comment.
Image filename missing erc20 prefix from naming convention
Medium Severity
The image file is named 0xA059080853B2f273A452424859a4701A1Ce13A0e.svg but other token images in this repository follow the naming pattern that includes the erc20: prefix (e.g., erc20:0x....svg). Even if the JSON logo field were corrected to use a relative path, the path would need to match this file's actual location. The mismatch between the expected naming convention and actual filename would prevent the logo from resolving correctly.
metadata/eip155:56/erc20:0xa059080853b2f273a452424859a4701a1ce13a0e.json
Outdated
Show resolved
Hide resolved
2 participants
This PR adds the metadata and logo for Midas Tech (MIDAS) BEP20 token on Binance Smart Chain.
The logo has been added in SVG format and JSON file created under metadata/eip155:56/.
Liquidity is already added on PancakeSwap and locked on PinkLock.
Note
Adds Midas Tech (MIDAS) token assets for BNB Smart Chain (chainId 56).
metadata/eip155:56/erc20:0xa059080853b2f273a452424859a4701a1ce13a0e.jsonwithname,symbol,decimals,address,website,description, andlogoURIimages/eip155:56/0xA059080853B2f273A452424859a4701A1Ce13A0e.svgWritten by Cursor Bugbot for commit 896a66e. This will update automatically on new commits. Configure here.