remove 'Types' case from render switch in GeneralInformation component#204
remove 'Types' case from render switch in GeneralInformation component#204ddelpiano merged 1 commit intoMetaCell:developmentfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the 'Types' case from the switch statement in the GeneralInformation component's renderProperty function, changing how 'Types' metadata is rendered in the term information display.
Changes:
- Removed the 'Types' case that was grouped with 'Tags' in the property rendering switch statement, causing 'Types' to be rendered as comma-separated text instead of as colored chips
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case 'Tags': | ||
| case 'Types': | ||
| return renderTags(value); |
There was a problem hiding this comment.
The PR description states "We were missing Types in the term info - Hopefully this fixes it", but removing the 'Types' case doesn't make Types appear if it was missing. Instead, it changes how Types are rendered. Previously, Types would be rendered as colored chips (via renderTags), but now they will fall through to the default case and be rendered as comma-separated text (lines 892-901). If Types was truly missing from term info, the fix would be to ensure Types data is being passed to the component, not to remove its special rendering. Please verify whether the intention is to change the rendering style from chips to text, or if there's a different issue being addressed.
2 participants
We were missing Types in the term info - Hopefully this fixes it