Skip to content

add check for commands from string #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

james-bruten-mo
Copy link
Contributor

Description

If an upgrade macro gets run multiple times as part of development, the automatically added "Commands From: ..." comment can get added a number of times. This adds a check that the comment doesn't already exist before writing it. I've checked that this works on an existing Apps branch with a macro.

Checklist

  • I have performed a self-review of my own changes

@james-bruten-mo james-bruten-mo requested a review from a team as a code owner July 16, 2025 16:30
@james-bruten-mo james-bruten-mo requested review from cameronbateman-mo and mo-nikosbaltas and removed request for a team July 16, 2025 16:30
Copy link
Contributor

@cameronbateman-mo cameronbateman-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible solution.

Copy link
Contributor

@cameronbateman-mo cameronbateman-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change and straightforward on what it does.

edit: well you get 2 reviews from me cause i missed the first one doing this one 🤣

Copy link

@mo-nikosbaltas mo-nikosbaltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible changes that fulfil requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants