Configurable sum of product styling #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiroptical
commented
Nov 15, 2021
Comment on lines
+1
to
+14
| @JsonClassDiscriminator("tag") | ||
| @Parcelize | ||
| @Serializable | ||
| sealed class Enum : Parcelable { | ||
| @Parcelize | ||
| @Serializable | ||
| @SerialName("dataCons0") | ||
| data class DataCons0(val contents: Record0) : Enum() | ||
|
|
||
| @Parcelize | ||
| @Serializable | ||
| @SerialName("dataCons1") | ||
| data class DataCons1(val contents: Record1) : Enum() | ||
| } No newline at end of file |
There was a problem hiding this comment.
@tadfisher Yeah?
chiroptical
commented
Nov 16, 2021
chiroptical
changed the title
chiroptical
force-pushed
the
tagged-object-option
branch
from
e25d3c9 to
72b0396
Compare
chiroptical
commented
Nov 18, 2021
|
|
||
| -- * Options for encoding types | ||
|
|
||
| -- ** Option type and defaults |
There was a problem hiding this comment.
The changes here are just passing options down to enumExp
There was a problem hiding this comment.
parsonsmatt
approved these changes
Dec 2, 2021
| -- | Make a void type (empty enum) | ||
| mkVoid :: | ||
| () => | ||
| Options -> |
There was a problem hiding this comment.
Feels like a good use of ReaderT Options - maybe put that in with MoatM?
There was a problem hiding this comment.
ah lol i see that you already have this as a refactoring potential!
There was a problem hiding this comment.
It is definitely getting tedious to pass these around over and over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much less intrusive version of #33. Introduce a configuration option to handle the various encoding styles of Aeson (see https://hackage.haskell.org/package/aeson-2.0.1.0/docs/Data-Aeson-TH.html#t:SumEncoding). We are using a non-existent style that was suggested in this PR.
Spawns a few issues: