add tasty integration notes #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
reviewed
Sep 12, 2024
docs/tasty-integration.md
Outdated
Comment on lines
26
to
28
| If you add a new test file, the top level [tasty-discover](https://hackage.haskell.org/package/tasty-discover) | ||
| module will not have it set up as a dependency, so will not be reloaded until you restart the `ghciwatch` process. [tasty-autocollect](https://hackage.haskell.org/package/tasty-autocollect) relies on a compiler plugin and seems to avoid | ||
| this problem. |
There was a problem hiding this comment.
This shouldn't be true - if ghciwatch sees an edit to the file that uses tasty-discover (or any other file that is a dependency of that module), then the GHC preprocessor plugin will run and include the newly created test file. You shouldn't need to restart ghciwatch.
docs/tasty-integration.md
Outdated
| bubblewrap :: IO () -> IO () | ||
| bubblewrap io = do | ||
| try io :: IO (Either SomeException ()) | ||
| hSetBuffering stdout NoBuffering |
There was a problem hiding this comment.
Is tasty changing the buffering mode? I'm curious if the benefit here is to set the NoBuffering mode, or if the benefit is just that we're flushing the buffer
9999years
previously approved these changes
Sep 13, 2024
|
OK, I rewrote this a little. I'm going to merge it now, let me know if you don't like any of my changes and we can sort it out. Also please try writing the top-level |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch,minor, ormajorto request a version bump when it's merged. (N/A, docs-only)docs/.tests/. (N/A, docs-only)