Skip to content

Conversation

@lbt
Copy link
Member

@lbt lbt commented Apr 1, 2017

This is currently deployed on Mer infra and works with the API GET/PUT
Triggers generally seem to work

lbt added 2 commits April 1, 2017 18:54
…oviding a value for the appropriate attr; in this case that's the _lsr private attribute of a WebHookMapping

Signed-off-by: David Greaves <[email protected]>
Copy link
Member

@keto keto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok except the URL part order.

I'm not yet so familiar with rest framework internals, that I could say much about the API serializers and views. But if they work, then it's fine for now.

"%s (%s/package/show?package=%s&project=%s)" % (
"%s (%s/package/show/%s/%s)" % (
self.project, self.package, self.obs.weburl,
self.package, self.project,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think package and project are backwards here for the new style OBS urls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants