Use rpm/precheckin.sh to generate spec files. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2015 16:35
Follows the specification as laid out by Thomas Perl in MeeGoIntegration#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the specification as laid out by @thp in issue #5, basically: if rpm/precheckin.sh exists, assume we can delete rpm/*.spec and generate them by running
sh precheckin.shin the rpm dir.Precheckin.sh is not run for dumb mode, but otherwise unconditionally (android, rpm and debian case)
There are no transitional features at the moment, so
running it against https://github.com/mer-packages/gdb.git fails because because of bashsims in its rpm/precheckin.sh (and then because the template is gdb.spec).
Question: Do we want to deal with these possible failure modes, or should the burden be on the other packages to update their packaging practices?