Merged
Conversation
|
|
warner-benjamin
requested changes
Oct 15, 2025
Collaborator
warner-benjamin
left a comment
warner-benjamin
left a comment
There was a problem hiding this comment.
Thanks for the PR. A few changes needed before it can be merged.
Assuming the authors don't state what their prompts are (I did a quick search and didn't find anything), we want to default to using verifiers' BOXED_SYSTEM_PROMPT and THINK_BOXED_SYSTEM_PROMPT for reasoning models. verifiers has a boxed format parser extract_boxed_answer in verifiers.utils.data_utils, and verifiers.ThinkParser to extract the answers from a reasoning model. Make sure to add the use_think: bool = False boolean flag so the user can opt into using the thinking prompt and parser. You can see an example of this in #19.
The LLM as a Judge implementation is incomplete and needs to be finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added environment for the CareQA dataset (#33).