check_config.h: move to library and test #10319
Merged
+93
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-ci
gilles-peskine-arm
added
size-s
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
This was referenced Jul 22, 2025
gilles-peskine-arm
added
needs-review
|
I think that
in the PR's description should be updated to |
valeriosetti
previously approved these changes
Jul 23, 2025
|
I've fixed the PR description. Let me know if you find similar copypasta in the code or in commit messages. |
bjwtaylor
previously approved these changes
Jul 23, 2025
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
This will be populated in subsequent commits. Signed-off-by: Gilles Peskine <[email protected]>
`check_config.h` only needs to run once on the configuration. It doesn't need to run every time an application is built. It used to be public up to Mbed TLS 2.x because it was included from `config.h`, and users could substitute that file completely and should still include `check_config.h` from their file. But since Mbed TLS 3.x, including `check_config.h` is a purely internal thing (done in `build_info.h`). So make the file itself purely internal. We don't need to include `check_config.h` when building every library file, just one: `mbedtls_config.c`, that's its job. Give the file a unique name, to avoid any clashes with TF-PSA-Crypto's `check_config.h`. Signed-off-by: Gilles Peskine <[email protected]>
This will be needed when TF-PSA-Crypto's `build_info.h` stops including `limits.h`, which it currently does by accident because it includes `check_config.h` which wants `limits.h` to check `CHAR_BIT`. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Ensure that `mbedtls_check_config.h` is taken into account. Signed-off-by: Gilles Peskine <[email protected]>
It was already deprecated since 3.0 (although we forgot to announce it in the changelog back then). Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
dismissed stale reviews from bjwtaylor and valeriosetti
via
fff4b32
gilles-peskine-arm
force-pushed
the
move-check-config-to-library
branch
from
256000d to
fff4b32
Compare
|
I rebased to handle the framework conflict. |
valeriosetti
approved these changes
Jul 29, 2025
gilles-peskine-arm
removed
the
needs-reviewer
bjwtaylor
approved these changes
Jul 29, 2025
gilles-peskine-arm
added
approved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The merge queue failed in what looks like a new variant of a DTLS intermittent failure. I'll requeue. |
Merged
via the queue into
Mbed-TLS:development
with commit Jul 29, 2025
d6f881e
4 of 6 checks passed
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_config.hout of the public includes. Resolves Move the inclusion of check_config.h to library #8105.check_config.htombedtls_check_config.h. Resolves part of Header files should have different names #9862.check_config.his taken into account.Needs preceding PR: Mbed-TLS/mbedtls-framework#192. The TF-PSA-Crypto and mbedtls PR can be merged independently.
PR checklist