Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ jobs:
- name: Build up-core-api conan package
shell: bash
run: |
conan create --version 1.6.0-alpha2 up-conan-recipes/up-core-api/release
conan create --version 1.6.0-alpha4 up-conan-recipes/up-core-api/release

- name: Build up-cpp conan package
shell: bash
run: |
conan create --version 1.0.1 --build=missing up-conan-recipes/up-cpp/release
conan create --version 1.0.1-dev --build=missing up-conan-recipes/up-cpp/developer

- name: Build zenohcpp conan package
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions conanfile.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[requires]
up-cpp/[^1.0.1]
up-cpp/[^1.0.1, include_prerelease]
zenohcpp/1.2.1
zenohc/1.2.1
spdlog/[~1.13]
up-core-api/[~1.6, include_prerelease]
up-core-api/1.6.0-alpha4
protobuf/[~3.21]

[test_requires]
Expand Down
2 changes: 1 addition & 1 deletion include/up-transport-zenoh-cpp/ZenohUTransport.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ struct ZenohUTransport : public UTransport {
/// @note The default implementation does nothing.
///
/// @param listener shared_ptr of the Connection that has been broken.
virtual void cleanupListener(CallableConn listener) override;
virtual void cleanupListener(const CallableConn& listener) override;

static std::string toZenohKeyString(
const std::string& default_authority_name, const v1::UUri& source,
Expand Down
2 changes: 1 addition & 1 deletion src/ZenohUTransport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ v1::UStatus ZenohUTransport::registerListenerImpl(
return registerPublishNotificationListener_(zenoh_key, listener);
}

void ZenohUTransport::cleanupListener(CallableConn listener) {
void ZenohUTransport::cleanupListener(const CallableConn& listener) {
subscriber_map_.erase(listener);
}

Expand Down