Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update view controller to use react native's new architecture #50

Merged
merged 10 commits into from
Dec 10, 2024

Conversation

MaxAst
Copy link
Owner

@MaxAst MaxAst commented Oct 23, 2024

addresses #42

@chris-sark
Copy link

@MaxAst is there an update on this? would love to use the new architecture asap. Thanks!

@MaxAst
Copy link
Owner Author

MaxAst commented Nov 21, 2024

@chris-sark this PR tries to add support for the new architecture to the share extension's view itself. Turns out this is really tricky and depends on this landing in react native core. I created an issue that explains what the challenge. In the meantime, I'm planning on trying to make the share extension support expo apps with new arch enabled, without actually using the new arch in the share extension's view. Will let you know once that lands, aiming for end of next week.

@MaxAst MaxAst marked this pull request as ready for review December 10, 2024 11:18
@MaxAst
Copy link
Owner Author

MaxAst commented Dec 10, 2024

not quite there yet with new architecture, as font scaling isn't working correctly. However, this PR fixes #61, so will release this already with RootViewFactory's newArchEnabled set to false for now

@MaxAst MaxAst merged commit 2024744 into main Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants