Broaden types converted to jsonb numeric #32563
Open
+23
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We detect a few scalar types that can convert into jsonb's numeric representation, but types we don't explicitly match are converted to strings.
Todo:
select jsonb_build_object('data', count(*)) from ..
.Putting up without this work to raise for discussion. Specifically, the code comments say
which .. isn't actually what happens (they are directly converted to
Numeric { max_scale: None }
). If it is important that something very close to that happens we should discuss, but we already convertNumeric
, which subsumes all of our integer types, intoNumeric
rather thanFloat64
or anything similar.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.