Skip to content

explain: remove Filter layer from OptimizerTrace stack #26679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aalexandrov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

explain: remove Filter layer from OptimizerTrace stack #26679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/adapter/src/explain/optimizer_trace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,16 +79,7 @@ impl OptimizerTrace {
.with(PlanTrace::<DataflowDescription<Plan>>::new(filter()))
// Don't filter for FastPathPlan entries (there can be at most one).
.with(PlanTrace::<FastPathPlan>::new(None))
.with(PlanTrace::<UsedIndexes>::new(None))
// All optimizer spans are `TRACE` and up. Technically this slows down the system
// by skipping the tracing fast path DURING an `EXPLAIN`, but we haven't
// seen this be a problem (yet).
//
// Note that we typically do NOT use global filters like this, preferring
// per-layer ones, but we are forced to because per-layer filters
// require an `Arc<dyn Subscriber + LookupSpan>`, which isn't a trait
// exposed by tracing, for now.
.with(tracing::level_filters::LevelFilter::TRACE);
.with(PlanTrace::<UsedIndexes>::new(None));

OptimizerTrace(dispatcher::Dispatch::new(subscriber))
} else {
Expand All @@ -103,8 +94,7 @@ impl OptimizerTrace {
.with(PlanTrace::<DataflowDescription<OptimizedMirRelationExpr>>::new(filter()))
.with(PlanTrace::<DataflowDescription<Plan>>::new(filter()))
.with(PlanTrace::<FastPathPlan>::new(None))
.with(PlanTrace::<UsedIndexes>::new(None))
.with(tracing::level_filters::LevelFilter::TRACE);
.with(PlanTrace::<UsedIndexes>::new(None));

OptimizerTrace(dispatcher::Dispatch::new(subscriber))
}
Expand Down