Skip to content

Fix Enhance Mouseover Visuals for TabControl #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

corvinsz
Copy link
Member

@corvinsz corvinsz commented Feb 28, 2025

fixes #3802

  • Sets the Cursor="Hand" when hovering over a TabItem
  • Added the same "hover effect" to TabItem which any normal Button has

Current behavior

tabControlPre

New behavior

tabControlPost

-change the Cursor on hover
-implement a "hover" effect
@jbooth88
Copy link
Contributor

Adding a highlight to the tab header on mouse-hover makes sense. However changing the mouse cursor does not follow the WPF framework defaults for the for tab control. I also checked winforms and winUI, neither change the mouse cursor when hovering over a tab item (provided default styles are applied).

@corvinsz
Copy link
Member Author

I would argue WPF defaults don't matter.
The purpose of this library is to bring Material Design to WPF, and the MD specs suggest what is proposed in this PR (as far as i have read it).
https://m3.material.io/components/tabs/accessibility#1f5832f9-1898-4da1-bfe4-f40c84027f8a

@@ -291,7 +291,7 @@
Duration="0" />
</Storyboard>
</ControlTemplate.Resources>
<Grid x:Name="Root">
<Grid x:Name="Root" Cursor="Hand">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than hard code this value here, lets set it in a Style setter that way if consumers want to change it, they can.
See the MaterialDesignRaisedButton for an example of doing this.

Copy link
Member Author

@corvinsz corvinsz Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keboo I intentionally placed the Cursor="Hand" property at that level. If I set it at the Style-level, the Cursor becomes a Hand when hovering over the content of the TabItem, which is not desired:
tabControlCursor

Maybe adding an attached property (e.g.: TabAssist.TabHeaderCursor) is the way to go? This way the cursor behaves the correct way, and consumers can change it, if they want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I had not considered that. Yes, let's go with the attached property approach.

@Keboo Keboo added this to the 5.3.0 milestone Mar 14, 2025
@corvinsz
Copy link
Member Author

  • I added a new attached property called TabAssist.TabHeaderCursor
  • The new default Cursor is the Hand
  • Consumers can force the old Cursor by setting the AP (e.g.: materialDesign:TabAssist.TabHeaderCursor="Arrow")

@nicolaihenriksen
Copy link
Contributor

I would argue WPF defaults don't matter. The purpose of this library is to bring Material Design to WPF, and the MD specs suggest what is proposed in this PR (as far as i have read it). https://m3.material.io/components/tabs/accessibility#1f5832f9-1898-4da1-bfe4-f40c84027f8a

I agree with @corvinsz. And often when I am in doubt when looking at the MD3 specs, I drop back to the MD2 specs where they have the interactive demos for many things. And that clearly shows the hand cursor on hover:
https://m2.material.io/components/tabs#interactive-demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Mouseover Visuals for TabControl
4 participants