incrementally remove explicit calls to free memory#194
Open
GDCCP wants to merge 4 commits intoMartinsos:masterfrom
Open
incrementally remove explicit calls to free memory#194GDCCP wants to merge 4 commits intoMartinsos:masterfrom
GDCCP wants to merge 4 commits intoMartinsos:masterfrom
Conversation
…s/createReverseCopy/and part of AlignmentData)
…in AlignmentData struct
… in calcEditDistance
using vector to make memory management implicit in buildPeq and parts…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am just replacing alloc/free with c++ unique_ptr/vector so that no explicit code needed to free memory. As there are internal API changes, the Issue84 PR after breakdown will likely become a sequence of PRs that should be applied in order.
This is the first one, and I don't think I can submit another one independently.