Add more browser to install in init #4565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for four additional browser options to the rfbrowser init command: chromium-headless-shell, chromium-tip-of-tree-headless-shell, bidi-chromium, and webkit-wsl. These new options align with the available browsers supported by Playwright, allowing users to install specific browser binaries needed for their testing environment.
Key Changes:
- Extended the browser choice list in the CLI argument definition to include four new browser types
- Updated the docstring to list all available browser options and added a note about platform-specific browser availability
aaltat
force-pushed
the
init_browsers
branch
from
fd7d5cc to
df58150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4559