MDEV-37052 JSON_SCHEMA_VALID stack overflow handling errors #4135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since MDEV-33209 (09ea2dc) the the stack overflow errors are just injected instead of frailer mechanisms to consume stack. These mechanims where not carried forward to the JSON_TABLE or JSON_SCHEMA_VALID where the pattern was the same. add_extra_deps also no-longer recursively iterates in out of stack conditions. Tests performed in json_debug_nonembedded(_noasan).
grooverdan
added
the
MariaDB Foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4134 covers the basics, however needed to copy some of the JSON_TABLE changes to be able to enable this to compile.
This extends the handling for JSON_SCHEMA_VALID too.
Since MDEV-33209 (09ea2dc) the the stack overflow errors are just injected instead of frailer mechanisms to consume stack. These mechanisms where not carried forward to the JSON_TABLE or JSON_SCHEMA_VALID where the pattern was the same.
add_extra_deps also no-longer recursively iterates in out of stack conditions.
Release Notes
debug mode only for this one.
How can this PR be tested?
Tests performed in json_debug_nonembedded(_noasan).
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check