MDEV-36531 Enable Feedback Plugin for DEB Packages #4021
Conversation
Revert "Remove feedback from Windows MSI" (a89f1fa) but change the default value to OFF
|
|
|
Note we have had https://salsa.debian.org/mariadb-team/mariadb-server/-/merge_requests/16 open for a long time. It was waiting for @cvicentiu to confirm what is the correct API URL as there was some confusion which of the alternatives is correct, and perhaps some confirmation that the system actually works end-to-end to be deployed now. Seems there are some stats now at https://mariadb.org/feedback-plugin/ so it is up and running again? |
| statistical information. This information is used by the developers to | ||
| improve MariaDB. Enabling this plugin is an easy way to help with MariaDB | ||
| development. Collected statistics, and more information on the plugin, | ||
| can be viewed at http://mariadb.org/feedback_plugin |
There was a problem hiding this comment.
http://mariadb.org/feedback_plugin says 404 not found. The MR in Debian links to https://mariadb.org/about/statistics/ which seems to redirect to https://mariadb.org/about/#usage-statistics, which links to pages that are all broken.
debian/mariadb-server.postinst
Outdated
| echo "# THIS IS A GENERATED FILE. ALL CHANGES TO IT MIGHT BE LOST."; | ||
| echo "[server]"; | ||
| if [ "$RET" = true ]; then | ||
| echo "enable-feedback"; |
There was a problem hiding this comment.
https://mariadb.com/kb/en/feedback-plugin/#enabling-the-plugin saysa:
[mariadb]
...
feedback=ON
Please choose what you consider the canonical way and use it everywhere to avoid confusion by having different settings in different places to do the same thing.
| @@ -167,6 +171,43 @@ | |||
| </Control> | |||
| <Control Id="BannerLine" Type="Line" X="0" Y="44" Width="370" Height="0" /> | |||
| </Dialog> | |||
|
|
|||
There was a problem hiding this comment.
I think dedicating full extra dialog to something that unimportant is bad user experience. It should be less clicking, not more clicking, and definitely not for feedback plugin. So, can you instead place that checkbox into an existing dialog, where database properties are configured? Now, that UTF8 checkbox is effectively a no-op, and needs to go, its screen real estate can be used by something else, e.g feedback thing. It needs of course less text, so we can cut
"wishful thinking" text, only leaving "collects anonymous statistical information" , which is accurate, and IMO enough .
Clarification- it turns out, in the last 10 years, This information was not used by the developers to improve MariaDB. Enabling this plugin was not an easy way to help with MariaDB development. Collected statistics, and more information on the plugin, could not be viewed at http://mariadb.org/feedback_plugin, most of the times.
I'm not sure how now it is going to change, but based on experience, can we be less generous with optimism and advertisement.
Also, please fix the comment. This checkbox was never ever enabled by default, I'm not sure what the comment was referring to.
Create a user facing question during installation step to allow users to choose whether to enable the feedback plugin or not.