MDEV-35461 Remove redundant checks for standard library functions #4017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove function checks that are guaranteed by C99 standards to reduce the excessive time spent during CMake configuration step. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
|
|
svoj
added
the
External Contribution
|
@vuvova in MDEV-35461 you suggested that these checks should be removed. Which means they have to be removed along with compatibility code spread across other files. Could you confirm it is still your preference? |
|
Yes, sure, why would we want garbage like |
svoj
requested changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit removes function checks for standard library functions that are guaranteed to be available when using C99 standards[1]. These include:
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
[1] https://www.dii.uchile.cl/~daespino/files/Iso_C_1999_definition.pdf
How can this PR be tested?
✅ Build succeed.
✅ All MTR tests pass.
Basing the PR against the correct MariaDB version
✅ This is a code change related to build performance improvement applicable to multiple versions, and the PR is based against the latest MariaDB development branch.
PR quality check
✅ I have checked the
CODING_STANDARDS.mdfile and my PR conforms to this where appropriate.✅ For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.