-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
MDEV-21510 optimizer trace should show the index name in the block chosen_access_method #3998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDEV-21510 optimizer trace should show the index name in the block chosen_access_method #3998
Conversation
@bsrikanth-mariadb there should be no need to create separate pull requests for the same issue. You could've restored #3995 by force pushing to your branch. |
Yeah, sure @svoj. But, my local repo was in a bad state as well. So, felt better to create a new PR. |
Please put tests and test changes in the same commit with code changes, it is needed for merge and code investications. |
Sure Sanja, will rebase before merging. |
You had to fix your local repo in the first place and then push it to github anyway. Not a big deal, but feel free to ask for help if something goes wrong. |
1c2f02e
to
0c42913
Compare
sure Sergey, Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the input.
Other than that, we're close to finish
Please make the PR have one commit, address the
part. |
cd65ef5
to
19bee15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And ok to push after the above is addressed.
05721a3
to
c94133a
Compare
Pull request created in: https://jira.mariadb.org/browse/MDEV-21510