MDEV-35816 ASAN use-after-poison in st_select_lex::print #3993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveGosselin-MariaDB
force-pushed
the
10.11-mdev-35816-asan-print
branch
from
ac11d3e to
e4a466d
Compare
Semi-joins with CTEs as the derived table will leave dangling pointers to the JOIN instance, from the corresponding SELECT_LEX instance, after first execution has completed. Clean these up during statement reinitialization, before subsequent executions occur.
DaveGosselin-MariaDB
force-pushed
the
10.11-mdev-35816-asan-print
branch
from
e4a466d to
2014c34
Compare
| // should have already been destroyed by this point. There's no way | ||
| // to assert that because it will result in EXC_BAD_ACCESS. | ||
| for (SELECT_LEX *sl= unit->first_select(); sl; sl= sl->next_select()) | ||
| sl->join= nullptr; |
There was a problem hiding this comment.
Maybe we need to recursively call this new function cleanup_joins from here? Just in case we have nested semi-joins with CTEs inside of those, and so on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-joins with CTEs as the derived table will leave dangling pointers to the JOIN instance, from the corresponding SELECT_LEX instance, after first execution has completed. Clean these up during statement reinitialization, before subsequent executions occur.