MDEV-23077: --flashback + --table produces buggy results #3968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Events of skipped tables were still queued and generates extraneous “Row event for unknown table” when flashing back. * Skipping a statement-end event left prior non-skipped events processed incompletely. Co-Authored-By: lukexwang <[email protected]>
ParadoxV5
commented
Apr 12, 2025
| --echo # | ||
| --echo # MDEV-30698 Cover missing test cases for mariadb-binlog options | ||
| --echo # --raw [and] --flashback | ||
| --echo # | ||
|
|
||
| --error 1 # --raw mode and --flashback mode are not allowed | ||
| --exec $MYSQL_BINLOG -vv -B --raw --read-from-remote-server --user=root --host=127.0.0.1 --port=$MASTER_MYPORT master-bin.000003> $MYSQLTEST_VARDIR/tmp/mysqlbinlog_row_flashback_8.sql | ||
| --exec $MYSQL_BINLOG -vv -B --raw --read-from-remote-server --user=root --host=127.0.0.1 --port=$MASTER_MYPORT master-bin.000003> $MYSQLTEST_VARDIR/tmp/mysqlbinlog_row_flashback_0.sql |
There was a problem hiding this comment.
We have a real Case 8 now.
| @@ -955,14 +955,14 @@ static bool print_row_event(PRINT_EVENT_INFO *print_event_info, Log_event *ev, | |||
| } | |||
|
|
|||
| /* skip the event check */ | |||
| if (skip_event) | |||
| if (skip_event && !(opt_flashback && is_stmt_end)) | |||
There was a problem hiding this comment.
What #1674 did was copy-pasting the else branch of the next if to the previous if tree as a new branch for (skip_event && opt_flashback && is_stmt_end).
Here, I reimplement it by skipping this intermediate “step” (?) for that exact condition.
While the diff is now smaller, it has become proof that our code is 🍝.
* Events of skipped databases were still queued and generates extraneous “Row event for unknown table” when flashing back. * Skipping a statement-end event left prior non-skipped events processed incompletely.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is the patch trying to solve?
How can this PR be tested?
#1674 provided a
< CASE 8 >forbinlog.flashbackwhich I simplified and corrected (?) to cover both bullet points.It also adds a
< CASE 9 >checking the similar--databaseexcludes the not-specified database.PR quality check
This is a new feature or a refactoring, and the PR is based against themainbranch.--databaseand--table.This PR excludes them.