CMAKE generator : allow options other than variables #881
+139
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanLiviuVarzaru
force-pushed
the
1-master-migration
branch
from
ec40b90 to
198c2f1
Compare
Prep step for migrating other builders to `master-migration`
RazvanLiviuVarzaru
force-pushed
the
1-master-migration
branch
from
198c2f1 to
55632ba
Compare
grooverdan
reviewed
Dec 1, 2025
Member
grooverdan
left a comment
grooverdan
left a comment
There was a problem hiding this comment.
minor improvements, otherwise ok.
RazvanLiviuVarzaru
force-pushed
the
1-master-migration
branch
from
ee1f9a6 to
aa8f326
Compare
Collaborator
Author
|
Thanks a lot for the review, @grooverdan ! Good comments. About |
grooverdan
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep step for migrating other builders to
master-migration