Mapster.EF.Core: Add type check for IAsyncEnumerable<> #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocSvartz
approved these changes
Oct 14, 2025
|
@ScarletKuro Can you do this using the development branch? |
Sure, do I leave this open tho? |
|
Yes, leave this open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #820
Fixes: #566 (was closed due to a workaround)
Description:
The issue occurs because the code always attempts to wrap the result in
MapsterAsyncEnumerable, even when the type does not implementIAsyncEnumerable. This fix ensures wrapping only happens if the type actually implementsIAsyncEnumerable, which prevents theMissingMethodExceptionto throw.