Raise an error if we don't know how to login to this type of site #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I may have mis-understood and this might not be why my login is failing. I'm not sure. I still get an error when I try to login to |
Manishearth
added a commit
that referenced
this pull request
Apr 21, 2014
Raise an error if we don't know how to login to this type of site
|
Once my vacation starts in May I'll be back to maintaining this. |
Manishearth
pushed a commit
that referenced
this pull request
Nov 23, 2016
Upgrade from 3 to 6 (Python2+3 support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize that the site code I was using was invalid, and that that was why the login was failing. It might make sense to add an error message in this case.